[EDR Workflows] Workflow Insights - migrate to Signature field #205323
+199
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
szwarckonrad
added
release_note:skip
tomsonpl
approved these changes
Jan 7, 2025
| @@ -122,7 +122,9 @@ export const WorkflowInsightsResults = ({ | |||
| {insight.message} | |||
| </EuiText> | |||
| <EuiText size={'xs'} color={'subdued'}> | |||
| {item.entries[0].type === 'match' && item.entries[0].value} | |||
| {item.entries[0].type === 'match' && | |||
There was a problem hiding this comment.
Just to make sure: we add more checks, so all of them have to be met in order to be valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks to verify whether the signer_id is present in file events stored in the ES, which serve as the foundation for generating endpoint insights. Previously, we relied solely on the executable path, which caused issues when a single AV generated multiple paths.
With these changes:
signer_idexists in the file event, it will be used for generating insights.signer_idis unavailable (e.g., Linux, which lacks signers), the executable path will still be used as a fallback.Screen.Recording.2024-12-31.at.15.31.24.mov